Repository navigation
Conversation
更新 B300 DSV4 DSpark 配置,启用 DP 推测解码与预填充协调,保留 TP4/TP8 低延迟测试点。
|
Thanks for the contribution!
中文感谢你的贡献!
|
补充 DSpark 提交的变更日志 PR 链接,修复矩阵规划校验失败。
There was a problem hiding this comment.
Beyond the inline finding, I checked the disable-circuit-breaker addition to the shared DEP8 router config and the max-running-requests cut to 768 for c512/c576 — both read as deliberate tuning tradeoffs rather than a missing safety guard or admission regression. I also confirmed the container image digest matches exactly between agentic.yaml and nvidia-master.yaml, and that none of the new env vars hardcode a synthetic acceptance length.
Extended reasoning...
The diff bumps the SGLang container image and reworks scheduling/memory/env knobs for the DSV4 B300 DSpark benchmark across the recipe, master config, and changelog; it touches no auth/crypto/permission surface. A confirmed inline finding already flags a missing required pr-link in the new changelog entry, which should block merge until fixed. I additionally verified image-digest parity between the recipe and master config (an AGENTS.md invariant) and ruled out two candidate concerns (circuit-breaker removal on the shared DEP8 router, reduced max-running-requests for c512/c576) as intentional tuning rather than bugs, and found no reintroduction of hardcoded synthetic acceptance lengths.
| - config-keys: | ||
| - dsv4-fp4-b300-sglang-agentic-hicache-mtp | ||
| scenario-type: | ||
| - agentic-coding | ||
| description: | ||
| - "Update B300 DSV4 DSpark performance with DP spec/prefill coordination, mixed 64K chunks and interval 32; retain TP4/TP8 low-latency coverage." | ||
| - "更新 B300 DSV4 DSpark 性能,启用 DP 推测解码与预填充协调、64K 混合分块和间隔 32;保留 TP4/TP8 低延迟测试点。" |
There was a problem hiding this comment.
🔴 The new changelog entry for dsv4-fp4-b300-sglang-agentic-hicache-mtp is missing the required pr-link: field, which every other entry in the file has. AGENTS.md requires this field, and infx/workflows/validate_perf_changelog.py's compare_entries() calls validate_added_pr_link(str(entry.get("pr-link") or ""), pr_number) on every newly added entry, raising ChangelogValidationError for an empty/missing link. Fix: append pr-link: https://github.com/SemiAnalysisAI/InferenceX/pull/<N> (or the XXX placeholder for PR runs) to this entry, matching every other block in the file.
Why this was flagged
The entry appended at inferencex-e2e/perf-changelog.yaml:9131-9137 (config-keys: dsv4-fp4-b300-sglang-agentic-hicache-mtp) has description lines but no pr-link: key. validate_perf_changelog.py's compare_entries() (called from the CI changelog check) iterates additions and calls validate_added_pr_link(str(entry.get("pr-link") or ""), pr_number); with the key absent this evaluates to an empty string, which fails CANONICAL_PR_LINK.fullmatch(link) (main-branch run) or the pr_number equality check (PR run), raising ChangelogValidationError. A repo-wide count confirms every other of the file's 1057 config-keys blocks has a matching pr-link line (1056 pr-link lines total), so this is the sole entry missing it, and the merge/CI gate for this PR will fail until it is added.
Verification: normal. The appended entry at inferencex-e2e/perf-changelog.yaml:9131-9137 (config-keys: dsv4-fp4-b300-sglang-agentic-hicache-mtp) contains only config-keys/scenario-type/description and no pr-link: key, whereas every other entry has one (lines 9110, 9122, 9129). validate_perf_changelog.py wires this into CI (.github/workflows/run-sweep.yml). compare_entries() collects additions = head_entries[len(base_entries):] and for each calls validate_added_pr_link(str(entry.get("pr-link") or ""), pr_number) (line 193).
|
View unofficial run (performance): https://inferencex.semianalysis.com/inference?unofficialRun=37841237652 View unofficial run (accuracy): https://inferencex.semianalysis.com/evaluation?unofficialRun=37841237652 |
更新 B300 DSpark 镜像至 2026-10-08 CUDA 13 开发版 nightly,合并最新 main 并解决变更日志冲突。
|
[by Claude Code] The SGLang cookbook integration of this PR's AgentX config ( |
|
[by Claude Code] sgl-project/sglang#43083 has been merged. This PR's AgentX config ( This PR has no authorized |
|
[by Claude Code] @Oasis-Git The full sweep for this PR is blocked by the new TP4 DSpark lane: the server hangs at startup every time (3 of 3 attempts). Could you debug it? Symptom. The fail-fast canary is
Where it stops. In the merged EAGLE TP4 recipe ( Suggestions.
The server logs are in each run's |
|
[by Claude Code] The SGLang cookbook update of this PR's AgentX config ( This PR has no authorized |
|
[by Claude Code] sgl-project/sglang#43983 has been merged. This PR's AgentX config ( This PR has no authorized |
更新 B300 DSV4 DSpark 配置,启用 DP 推测解码与预填充协调,保留 TP4/TP8 低延迟测试点。